[docker] Improve the way we extract image name and tag #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. |
hkaj
force-pushed
the
haissam/docker-image-tag-fix
branch
from
bf65e56 to
eaf1ea0
Compare
hkaj
force-pushed
the
haissam/docker-image-tag-fix
branch
2 times, most recently
from
34031a0 to
73e121d
Compare
| ({'Image': 'nginx:latest'}, ['nginx', 'latest']), | ||
| ({'Image': 'localhost/nginx:latest'}, ['localhost/nginx', 'latest']), | ||
| ({'Image': 'localhost:5000/nginx:latest'}, ['localhost:5000/nginx', 'latest']), | ||
| ] |
|
Added my feedback. |
hkaj
force-pushed
the
haissam/docker-image-tag-fix
branch
from
73e121d to
8debbf1
Compare
|
Thanks @yannmh I fixed a bunch of things and replied to your other comments, let me know what you think. |
|
Feel free to merge 🌵 |
hkaj
added a commit
that referenced
this pull request
Dec 8, 2015
[docker] Improve the way we extract image name and tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.