[core] supervisor.conf to select Supervisor user
#2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, Supervisor runs with the given `user` in the `supervisord` section of the `supervisor.conf` configuration file. > If supervisord is run as the root user, switch users to this UNIX user account before doing any meaningful processing. This value has no effect if supervisord is not run as root. (c.f http://supervisord.org/configuration.html#supervisord-section-settings) Thus, forcing Supervisor to run as `dd-agent` in the init script file is simply an extra precaution. However, it makes impossible to change UNIX users running the agent subprocesses via the `supervisor.conf` configuration file only. Drop this constraint.
|
@degemer can you take a pass on it ? |
|
Looks good to me, let's make sure to test that thoroughly. 👍 @olivielpeau possible to add more tests cases in dd-agent-testing with different values in the supervisord.conf ? |
yannmh
added a commit
that referenced
this pull request
Nov 6, 2015
[core] `supervisor.conf` to select Supervisor user
|
@remh I've added a few tests to dd-agent-testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Supervisor runs with the given
userin thesupervisordsection of the
supervisor.confconfiguration file.Thus, forcing Supervisor to run as
dd-agentin the init script file issimply an extra precaution. However, it makes impossible to change UNIX
users running the agent subprocesses via the
supervisor.confconfiguration file only.
Drop this constraint.