[core] Normalize exit code of fallback status command
#1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exit code of the `status` command has to be one of 0, 1, 2, 3, 4, 69 to be correctly understood by Ansible, but was returning `253` when the agent was not running on linux kernel versions 3.18+ Normalize the exit code to 0 or 1 to avoid the issue. See https://github.com/ansible/ansible-modules-core/blob/cbbb20b6bf0d82fdc92f064c9e4d18c04f203da6/system/service.py#L590 Fixes #1976
|
👍 |
remh
pushed a commit
that referenced
this pull request
Oct 21, 2015
…us-code [core] Normalize exit code of fallback `status` command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exit code of the
statuscommand has to be one of 0, 1, 2, 3, 4,69 to be correctly understood by Ansible, but was returning
253when the agent was not running on linux kernel versions 3.18+
Normalize the exit code to 0 or 1 to avoid the issue.
See https://github.com/ansible/ansible-modules-core/blob/cbbb20b6bf0d82fdc92f064c9e4d18c04f203da6/system/service.py#L590
Fixes #1976
More generally we could try to stick more closely to the LSB specs for the exit code of the
statuscommand.