[windows] add flare function #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _, temp_path = tempfile.mkstemp(prefix='dd') | ||
| with open(temp_path, 'w') as temp_file: | ||
| fh, temp_path = tempfile.mkstemp(prefix='dd') | ||
| with os.fdopen(fh, 'w') as temp_file: |
There was a problem hiding this comment.
👍
We should probably check those lines too as they also use tempfile.mkstemp:
Add a Windows flare function inside the GUI, using only popups (because it's the easiest way to do this). Flare: reuse filehandle instead of file path (filehandle was not closed, causing issues on Windows)
degemer
force-pushed
the
quentin/flare-windows
branch
from
9b9c675 to
279111e
Compare
|
LGTM! 👏 |
olivielpeau
added a commit
that referenced
this pull request
Jul 27, 2015
[windows] add flare function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Windows flare function inside the GUI, using only popups (because it's
the easiest way to do this).