[redis] handle exception when CONFIG disabled #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On AWS Elasticache, Redis config command is disabled by default. We only use it to get the max_slow_entries (and we have a default), so now it tries to get it from the config and catch potential errors, defaulting to the DEFAULT_MAX_SLOW_ENTRIES.
|
👍 |
remh
pushed a commit
that referenced
this pull request
Jul 27, 2015
[redis] handle exception when CONFIG disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On AWS Elasticache, Redis config command is disabled by default. We only use it
to get the max_slow_entries (and we have a default), so now it tries to get it
from the config and catch potential errors, defaulting to
DEFAULT_MAX_SLOW_ENTRIES.