Yann/rebased fluentd #1623
Merged
Yann/rebased fluentd #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoCavaille
force-pushed
the
yann/rebased-fluentd
branch
from
4448416 to
81a72d2
Compare
Now we can use either fluentd plugin_id or type as a tag. [[email protected]] rebase current work to solve merge conflicts
LeoCavaille
force-pushed
the
yann/rebased-fluentd
branch
from
81a72d2 to
6426c81
Compare
Limit `tag_by` parameter to `plugin_id` or `type` only, to prevent empty or bad tagging. Minor cosmetic changes too.
LeoCavaille
force-pushed
the
yann/rebased-fluentd
branch
from
6426c81 to
58c3993
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased of #1449. Thanks a lot @yyamano !
Added my two cents: limit
tag_byparameter toplugin_idortypeonly, to prevent empty or bad tagging + some minor cosmetic changes