[core] run supervisor as dd-agent #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does it play with the supervisor log file ? |
|
It won't be an issue, log files are chowned during the upgrade/install: https://github.com/DataDog/dd-agent-omnibus/blob/84a549d7c5dcdac7b59ccb067cdc23eede141110/package-scripts/datadog-agent/postinst#L52 |
|
Let's test it once the migration to omnibus 4 is done. |
|
This is planned for the 5.6.0 |
|
This also fix #1895 |
remh
force-pushed
the
quentin/run-supervisor-as-ddagent
branch
from
5474095 to
e16af2a
Compare
We don't need to run supervisor as root anymore, and it's _safer_ to avoid doing that. [skip ci]
remh
force-pushed
the
quentin/run-supervisor-as-ddagent
branch
from
e16af2a to
6837c53
Compare
|
dd-agent-testing passes on this branch, merging. |
remh
pushed a commit
that referenced
this pull request
Oct 1, 2015
[core] run supervisor as dd-agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to run supervisor as root anymore.
Tested on:
Will launch a
dd-agent-testingon them.