Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to Elasticsearch events #1444

Merged
merged 1 commit into from
May 6, 2015
Merged

Conversation

garnermccloud
Copy link
Contributor

No description provided.

@LeoCavaille
Copy link
Member

@elafarge please rebase this PR on master and re-run the test suite (runs it on 5 different versions of ES).

@elafarge elafarge force-pushed the elasticsearch-event-tags branch from 72c2181 to 7db7b6f Compare May 6, 2015 18:10
@elafarge
Copy link
Contributor

elafarge commented May 6, 2015

Done

@LeoCavaille
Copy link
Member

@elafarge I might be wrong, but where are self.config and self.curr_config defined?
Looks like the code is still using the old implementation of the check :/ ?

@elafarge elafarge force-pushed the elasticsearch-event-tags branch from 7db7b6f to 34c3908 Compare May 6, 2015 21:28
@elafarge
Copy link
Contributor

elafarge commented May 6, 2015

You're not wrong. My bad, I fixed didn't completely fix that rebase conflict :s. I'm rather surprised it went through our pylint check though 0_o . This is now fixed. Rerunning tests.

@LeoCavaille LeoCavaille force-pushed the elasticsearch-event-tags branch from 34c3908 to f672b8c Compare May 6, 2015 22:41
@LeoCavaille
Copy link
Member

👍

@LeoCavaille LeoCavaille force-pushed the elasticsearch-event-tags branch from f672b8c to d8469af Compare May 6, 2015 22:45
It just adds the tags given in the YAML config to the ES events when the
cluster status changes.
@LeoCavaille LeoCavaille force-pushed the elasticsearch-event-tags branch from d8469af to 547f8c9 Compare May 6, 2015 22:46
@LeoCavaille LeoCavaille merged commit 547f8c9 into master May 6, 2015
@LeoCavaille LeoCavaille deleted the elasticsearch-event-tags branch May 6, 2015 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants