Add service check to the SNMP check #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LotharSee
changed the title
| tags = ["snmp_device:%s" % ip_address] | ||
| if "service_check_error" in instance: | ||
| self.service_check(service_check_name, AgentCheck.CRITICAL, tags=tags, | ||
| message=instance["service_check_error"]) |
There was a problem hiding this comment.
If we look at line 140/141, we can set service_check_error without raising, and because you never reset this key in the instance dict, it will fail indefinitely?
There was a problem hiding this comment.
I kept the previous logic around error_indication and error_status, however in both case I'll return a ERROR service check.
So this service check will be ERROR if we get at least one error somewhere, OK otherwise.
|
Looks good overall! Thanks for adding some tests 👍 |
LeoCavaille
added a commit
that referenced
this pull request
Dec 22, 2014
Add service check to the SNMP check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a service check "snmp.can_check".
Since
pysnmpdoesn't distinguish network errors, MIB errors, ... I only report a check if we manage to collect all the metrics properly.In the same time:
I also thought about building service check from the configuration (report a specific OID as a service check) but I'm not sure that it makes sense/it is useful. So I think that it's good for now!