Add a varnish service check. #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@conorbranagan we can specify the same setup guidelines that we give in the postfix check: The "have better experience when check needs root access" is on the new agent core roadmap. |
| proc = subprocess.Popen(cmd, stdout=subprocess.PIPE) | ||
| output, _ = proc.communicate() | ||
| if varnishadm_path: | ||
| self._parse_varnishadm(varnishadm_path) |
There was a problem hiding this comment.
In these two last lines, you probably meant output instead of varnishadm_path?
conorbranagan
force-pushed
the
conor/varnish-service-check
branch
from
70f49b9 to
63453b0
Compare
|
Updated to use sudo now and fixed that other issue. Thanks. |
| # privilleges. You can configure your sudoers file for this: | ||
| # | ||
| # example /etc/sudoers entry: | ||
| # dd-agent ALL=(ALL) NOPASSWD:/usr/bin/find |
There was a problem hiding this comment.
s/find/varnishadm/ :rocket:
There was a problem hiding this comment.
Oops! Copypasta
The service check uses the `varnishadm debug.health` command to get the health of available backends. One check per backend will be submitted, tagged by the backend name. The BIG question here is how we will let users enable this because the varnishadm command requires access to the secret key which has root permissions by default (and is owned by root).
conorbranagan
force-pushed
the
conor/varnish-service-check
branch
from
63453b0 to
e28661b
Compare
|
😄 thanks! |
LeoCavaille
added a commit
that referenced
this pull request
Dec 10, 2014
Add a varnish service check.
| output, error = proc.communicate() | ||
| if error and len(error) > 0: | ||
| self.log.error(error) | ||
| self._parse_varnishstat_metrics(varnishstat_path, use_xml, tags) |
There was a problem hiding this comment.
you should pass "output" instead of "varnishstat_path" here.
See pullrequest #1377
LeoCavaille
pushed a commit
that referenced
this pull request
Feb 19, 2015
Another change from #1213 introduced a regression by passing the path of the command instead of the output of the comand.
LeoCavaille
pushed a commit
that referenced
this pull request
Feb 19, 2015
Another change from #1213 introduced a regression by passing the path of the command instead of the output of the comand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service check uses the
varnishadm debug.healthcommand toget the health of available backends. One check per backend will
be submitted, tagged by the backend name.
The BIG question here is how we will let users enable this because
the varnishadm command requires access to the secret key which has
root permissions by default (and is owned by root).
I don't know what the answer is yet but this will open up the discussion.