Add CouchDB service check. #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorbranagan
force-pushed
the
conor/couchdb-service-check
branch
from
3ec3d82 to
849ecdf
Compare
|
|
||
| @attr(requires='couchdb') | ||
| class CouchDBTestCase(unittest.TestCase): | ||
|
|
||
| def testMetrics(self): | ||
|
|
||
| def tetst_metrics(self): |
conorbranagan
force-pushed
the
conor/couchdb-service-check
branch
from
849ecdf to
70bf629
Compare
Pretty much the same as how it works in Couchbase with a test.
conorbranagan
force-pushed
the
conor/couchdb-service-check
branch
from
70bf629 to
72274e2
Compare
| tags=service_check_tags, message=str(e)) | ||
| raise | ||
| else: | ||
| self.service_check(self.SERVICE_CHECK_NAME, AgentCheck.OK) |
There was a problem hiding this comment.
You probably want to include the service_check_tags in here?
|
Fixed @LeoCavaille, thanks. Should be good now. |
LeoCavaille
added a commit
that referenced
this pull request
Dec 10, 2014
Add CouchDB service check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much the same as how it works in Couchbase with a test.