-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded Docker check for Agent 5.1 #1162
Conversation
def _is_container_included(self, instance, tags): | ||
def _is_tag_included(tag): | ||
for exclude_rule in instance.get("exclude") or []: | ||
if re.match(exclude_rule, tag): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think most people would assume re.search
instead of re.match
here. Or maybe just specify this clearly in the documentation?
Looks good to me! Question for you @LotharSee , how hard do you think it would be to have a docker test suite? |
Not that hard, but I never played with Travis. But it's definitively something that I'd like to do (and that we SHOULD do). |
Upgraded Docker check for Agent 5.1
Many bugs and feature requests were reported for this check, this PR should address most of them.
docker.containers.running
by image nametotal_*
useless metrics