Better SmartOS support in the process checker #1073
Conversation
Updated the code to reflect the folllowing: - psutil on SmartOS does not report shared - SmartOS is unix, has file descriptors - SmartOS does have ctx switching information Updates - Sets `real` to None (like win32) - Moves the check for is_unix (and file descriptors) out of the is_win32 branch - Looser coupling - Moves the check for ctx switching out of the `real is not None` branch - Looser coupling
|
Thanks @djensen47 . We'll review it soon and are aiming to get it released with version 5.1.0 of the agent. Thanks a lot! |
|
It looks good. Thanks! |
|
Actually it looks like your branch is not up to date with the latest master. Could you rebase your branch please ? |
|
I'll look into it this weekend. |
|
@djensen47 Any update to rebase ? |
|
I forgot about it. I think I need to create a user story on my side so this doesn't get lost. |
|
Ping @djensen47 the release of 5.2, will probably be some time around January. Just need a rebase and to go through the CI one more time, and then we'll be able to merge it! |
|
I've kicked the can down the road too long, I'm looking at it now should have something soon. |
Made slight changes in the merge: - Removed redundant exception check. Conflicts: checks.d/process.py
|
Looks like the build failed but unrelated to this change (I think). The mongo test timed out. |
|
Thanks a lot @djensen47 ! |
Better SmartOS support in the process checker
Updated the code to reflect the folllowing:
Updates
realto None (like win32)branch
real is not Nonebranch