Instrument check runs time in collector when enabled #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # trying to connect to the local endpoint: http://169.254.169.254 | ||
| # See http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/AESDG-chapter-instancedata.html | ||
| # and https://developers.google.com/compute/docs/metadata | ||
| # for more information | ||
| # collect_instance_metadata: yes | ||
|
|
||
| # If enabled the collector will capture a metric for check run times. | ||
| # check_timings: false |
There was a problem hiding this comment.
Tiny tiny nitpick, could you set the default to "no" instead of "false" for consistency purposes ?
|
Looks great! |
For consistency with the rest of config.
|
Updated and test added. Should be good to go if Travis passes... |
| @@ -59,7 +60,7 @@ def __init__(self, agentConfig, emitters, systemStats): | |||
| self.continue_running = True | |||
| self.metadata_cache = None | |||
| self.initialized_checks_d = [] | |||
| self.init_failed_checks_d = [] | |||
| self.init_failed_checks_d = {} | |||
There was a problem hiding this comment.
Nevermind looks like you're fixing a bug..
|
Looks good! |
remh
pushed a commit
that referenced
this pull request
Jul 7, 2014
Instrument check runs time in collector when enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option is in
datadog.confcalledcheck_timings.