Make the metric optional for the timed decorator. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the metric is NOT provided, it defaults to the function's module and name.
|
Great feature ! Thanks again @clokep. Merging it for the next release. |
yannmh
added a commit
that referenced
this pull request
Jul 23, 2015
Make the metric optional for the timed decorator.
|
Thanks! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the metric is NOT provided, it defaults to the function's module and name.
I find this convenient to wrap some functions where the metric is simply going to be the name of the function, in particular to wrap celery tasks.
I discussed this briefly with @remh on IRC and he suggested I put up a PR and we can discuss it.