[api] set follow_redirects=False on App Engine; recommended in docs #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation at the following URL states: "Explicitly set follow_redirects=False when calling Urlfetch, as it avoids a heavier-weight service designed to follow redirects." I have not been able to measure any significant difference, but since the Datadog API doesn't use redirects, this should be a safe change. Source: https://cloud.google.com/appengine/docs/python/microservice-performance#use_the_shortest_route
|
Thanks @evanj 🙇 The Datadog API does not indeed use redirects. Your changes are much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation at the following URL states: "Explicitly set
follow_redirects=False when calling Urlfetch, as it avoids a heavier-weight
service designed to follow redirects." I have not been able to measure any
significant difference, but since the Datadog API doesn't use redirects,
this should be a safe change. Source:
https://cloud.google.com/appengine/docs/python/microservice-performance#use_the_shortest_route
We will be using this in production at Bluecore very shortly. Happy to abandon this or sign a CLA or whatever you might want me to do. Thanks!