[dogshell][py3] print usage when no argument #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannmh
force-pushed
the
yann/dogshell-py3
branch
from
05bd740 to
8e67720
Compare
In accordance with the behavior on Python 2.x, `dog` command with Python 3.x should print the usage when no subparser is specified. Instead, the uncalled code block is executed and raises: ``` AttributeError: 'Namespace' object has no attribute 'func' ``` Fix it and print usage. More information: http://bugs.python.org/issue16308 Fix #85
yannmh
force-pushed
the
yann/dogshell-py3
branch
2 times, most recently
from
33accd9 to
62288c3
Compare
Improve compatibility with Python 3.x.
yannmh
force-pushed
the
yann/dogshell-py3
branch
from
62288c3 to
f46d1b2
Compare
yannmh
changed the title
|
Another one for you @JohnLZeller 😄 |
|
👍 :) Don't forget to squash! |
yannmh
added a commit
that referenced
this pull request
Mar 11, 2016
[dogshell][py3] print usage when no argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[dogshell][py3] print usage when no argument
In accordance with the behavior on Python 2.x,
dogcommand withPython 3.x should print the usage when no subparser is specified.
Instead, the uncalled code block is executed and raises:
Fix it and print usage.
More information: http://bugs.python.org/issue16308
Fix #85
[py3] better compatibility
Improve compatibility with Python 3.x.