Actually enforce apt and yum versions in the metadata.rb file
#874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urseberry
approved these changes
Dec 16, 2022
bkabrda
reviewed
Dec 19, 2022
metadata.rb
Outdated
|
|
||
| # Use '< 5.0' with Chef < 12.14 | ||
| if Chef::VERSION < Gem::Version.new(12.14) | ||
| depends 'yum', '< 5.0' |
There was a problem hiding this comment.
So this should be both >= 3.0 and < 5.0, right?
There was a problem hiding this comment.
Right ! Nice catch, fixed in 166fd1f.
chouetz
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enforces the
aptandyumversions in themetadata.rbfile.Motivation
The
aptandyumdependencies needed versions were explained in themetadata.rbfile but just as comments:This was also described in the
README.mdfile.This is not really user-friendly neither the best way of doing so since we can just add some logic in the
metadata.rbfile to deal with these cases.Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist