Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log_to_console To datadog.yaml #760

Merged

Conversation

nilskuehme
Copy link
Contributor

No description provided.

@nilskuehme nilskuehme requested a review from a team as a code owner December 6, 2020 15:38
@nilskuehme
Copy link
Contributor Author

Seems there is something wrong with the kitchen Centos 6 image:
[...] Status: Downloaded newer image for datadog/docker-library:chef_kitchen_systemd_centos_6 [...] Error: Cannot find a valid baseurl for repo: base YumRepo Error: All mirror URLs are not using ftp, http[s] or file. Eg. Invalid release/repo/arch combination/ removing mirrorlist with no valid mirrors: /var/cache/yum/x86_64/6/base/mirrorlist.txt STDERR: The command '/bin/sh -c yum install -y sudo openssh-server openssh-clients which curl' returned a non-zero code: 1 [...]
Tried to run Docker container manually:
docker run -idt datadog/docker-library:chef_kitchen_systemd_centos_6 f154335cb421d3db2ecfc10a3f32533f025d3add47920fd0b1eaa596cf29ca44
Got same error:
$ docker container ls -a CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES f154335cb421 datadog/docker-library:chef_kitchen_systemd_centos_6 "/root/start.sh" 2 seconds ago Exited (139) 1 second ago pensive_grothen

Extracted layer of the image and checked base repo list:
[base] name=CentOS-$releasever - Base mirrorlist=http://mirrorlist.centos.org/?release=$releasever&arch=$basearch&repo=os&infra=$infra #baseurl=http://mirror.centos.org/centos/$releasever/os/$basearch/ gpgcheck=1 gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-6 [...]
While trying to resolve http://mirrorlist.centos.org/?release=$releasever&arch=$basearch&repo=os&infra=$infra getting the same error as above: Invalid release/repo/arch combination

Image has been changed 1 year ago the last time. Not sure what changed or what to do to solve that issue.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nilskuehme thanks for your contribution! Don't worry about the CentOS 6 issue: CentOS 6 reached its end of life very recently and we need to update the image to keep testing on this platform.

Your change LGTM. Note that you can already set arbitrary config values throuygh the extra_config setting, see #758 (comment) for details. Nonetheless, since this can be useful for other folks I will be merging this.

@mx-psi mx-psi merged commit 252589b into DataDog:master Dec 7, 2020
@nilskuehme
Copy link
Contributor Author

@mx-psi ah yeah that makes sense. Maybe they moved the mirror or whatever then.

Great, thank you.

@nilskuehme nilskuehme deleted the Add-log_to_console-To-datadog.yaml branch December 7, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants