[chef][windows] allow custom prefix when specifying agent artifact+ve… #634
Conversation
There was a problem hiding this comment.
A few comments, overall LGTM!
Of course, a review from @remeh will be necessary as well :)
Also, let's mention in the PR description the use cases for this. In particular, a user installing released Agents should never have to specify this new attribute
metadata.rb
Outdated
| @@ -4,7 +4,7 @@ | |||
| license 'Apache-2.0' | |||
| description 'Installs/Configures datadog components' | |||
| long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) | |||
| version '3.1.0' | |||
| version '3.1.1' | |||
There was a problem hiding this comment.
version bump should be removed from PR
There was a problem hiding this comment.
Yeah, we're using this from the QA env, so I needed the bump. But we'll remove that before merging.
There was a problem hiding this comment.
Let's remove this and merge to master!
recipes/_install-windows.rb
Outdated
| @@ -40,8 +40,11 @@ | |||
| dd_agent_latest = 'ddagent-cli-latest' | |||
| end | |||
|
|
|||
| # If a different file prefix is specified, use that: | |||
| dd_agent_installer_prefix = node['datadog']['windows_installer_prefix'] ? node['datadog']['windows_installer_prefix'] : 'ddagent-cli' | |||
There was a problem hiding this comment.
The attribute windows_installer_prefix must be added to attributes/default.rb, and documented there.
Also, nit: for consistency with other Windows-related attributes, I slightly prefer a name such as windows_agent_installer_prefix, even though it's longer
Co-Authored-By: Olivier Vielpeau <[email protected]>
…adog into jaime/win_custom_prefix
metadata.rb
Outdated
| @@ -4,7 +4,7 @@ | |||
| license 'Apache-2.0' | |||
| description 'Installs/Configures datadog components' | |||
| long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) | |||
| version '3.1.0' | |||
| version '3.1.1' | |||
There was a problem hiding this comment.
Let's remove this and merge to master!
…rsion