Add missing options for rabbitmq collector #232
Conversation
mattrobenolt
force-pushed
the
rabbitmq
branch
from
00e9070 to
63c80ea
Compare
| @@ -6,10 +6,40 @@ instances: | |||
| - rabbitmq_api_url: <%= i['api_url'] %> | |||
| rabbitmq_user: <%= i['user'] || 'guest' %> | |||
| rabbitmq_pass: <%= i['pass'] || 'guest' %> | |||
| tags: | |||
There was a problem hiding this comment.
This also makes tags get rendered out optionally since it doesn't make too much sense to render an empty tags key if none are passed. It's also an ambiguous data type in yaml. The correct form for an empty list would be: tags: [], which it wasn't doing anyways.
|
Hi @mattrobenolt! Thanks for taking the time. We're trying to get into a model where the templates are simpler, and can be rendered from any Hash, allowing us to not have to update & release after any change in the Agent config. This leads to simpler template code, and becomes a bit easier to maintain. If you'd like to take the time to revisit this, we'd appreciate it! |
|
@miketheman is there a rewrite pending for converting to use any hash? If not this PR fixes a major problem for folks monitoring large rabbitmq setups. |
Adds the following: nodes, nodes_regexes, queues, queues_regexes, and vhosts