Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix dependency issue #1549

Merged
merged 1 commit into from
May 18, 2022
Merged

🐛 Fix dependency issue #1549

merged 1 commit into from
May 18, 2022

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented May 18, 2022

Motivation

fixes #1547

Changes

Avoid circular dependency around internalMonitoring and endpointBuilder

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

Codecov Report

Merging #1549 (22dd9a8) into main (bcd66bf) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1549   +/-   ##
=======================================
  Coverage   90.48%   90.48%           
=======================================
  Files         116      117    +1     
  Lines        4479     4479           
  Branches     1005     1005           
=======================================
  Hits         4053     4053           
  Misses        426      426           
Impacted Files Coverage Δ
...s/core/src/domain/configuration/endpointBuilder.ts 100.00% <ø> (ø)
...src/domain/configuration/transportConfiguration.ts 100.00% <ø> (ø)
...rc/domain/internalMonitoring/internalMonitoring.ts 95.94% <ø> (ø)
...kages/core/src/domain/configuration/intakeSites.ts 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@bcaudan bcaudan marked this pull request as ready for review May 18, 2022 11:52
@bcaudan bcaudan requested a review from a team as a code owner May 18, 2022 11:52
@bcaudan bcaudan merged commit e82a1f8 into main May 18, 2022
@bcaudan bcaudan deleted the bcaudan/fix-dependency-issue branch May 18, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@datadog/browser-rum broken with NextJS in versions >= 4.10.1
4 participants