Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: update banner components (#253) #255

Merged
merged 1 commit into from
Nov 5, 2024
Merged

feat!: update banner components (#253) #255

merged 1 commit into from
Nov 5, 2024

Conversation

frano-m
Copy link
Contributor

@frano-m frano-m commented Nov 1, 2024

Closes #253.

@frano-m frano-m requested a review from NoopDog November 1, 2024 04:55
@frano-m frano-m marked this pull request as draft November 1, 2024 04:55
MillenniumFalconMechanic
MillenniumFalconMechanic approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@MillenniumFalconMechanic MillenniumFalconMechanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frano-m frano-m marked this pull request as ready for review November 5, 2024 23:28
@MillenniumFalconMechanic MillenniumFalconMechanic removed the request for review from NoopDog November 5, 2024 23:42
@NoopDog NoopDog merged commit d9c87c7 into main Nov 5, 2024
2 checks passed
@MillenniumFalconMechanic MillenniumFalconMechanic deleted the fran/253-banner branch November 5, 2024 23:43
@NoopDog NoopDog mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MillenniumFalconMechanic MillenniumFalconMechanic MillenniumFalconMechanic approved these changes

Assignees

@NoopDog NoopDog

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Banner components
3 participants
@frano-m @MillenniumFalconMechanic @NoopDog