-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DCJ-387: Promote DAA functionality to staging #2625
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Two quick things:
I think we need to pull develop into this branch— there's one more PR that got merged that is using the (checkEnv(envGroups.DEV)
that we can replace with the DAAUtils.isEnabled()
call.
Also, I believe with this promotion, we will also have to upload DAAs, most importantly a Broad DAA to staging consent— there currently are no DAAs uploaded to staging so some of the pages on staging are breaking (DAA Associations, DAR form, etc.). Essentially the work of https://broadworkbench.atlassian.net/browse/DCJ-389 but on a much smaller scale for staging.
For staging, we can add a Dac DAA manually and set up DAA relations for everyone. |
# Conflicts: # src/Routes.jsx
@aarohinadkarni - This is now complete, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! 👍
Addresses
https://broadworkbench.atlassian.net/browse/DCJ-387
Summary
Have you read Terra's Contributing Guide lately? If not, do that first.