Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCJ-387: Promote DAA functionality to staging #2625

Merged
merged 6 commits into from
Jul 18, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Jul 16, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-387

Summary

  • Update all DAA related functionality so it is available on staging
  • Centralizes the logic in a utility that can serve as a foundation for common DAA logic.

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong marked this pull request as ready for review July 16, 2024 13:24
@rushtong rushtong requested a review from a team as a code owner July 16, 2024 13:24
@rushtong rushtong requested review from fboulnois and aarohinadkarni and removed request for a team July 16, 2024 13:24
Copy link
Contributor

@aarohinadkarni aarohinadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Two quick things:

I think we need to pull develop into this branch— there's one more PR that got merged that is using the (checkEnv(envGroups.DEV) that we can replace with the DAAUtils.isEnabled() call.

Also, I believe with this promotion, we will also have to upload DAAs, most importantly a Broad DAA to staging consent— there currently are no DAAs uploaded to staging so some of the pages on staging are breaking (DAA Associations, DAR form, etc.). Essentially the work of https://broadworkbench.atlassian.net/browse/DCJ-389 but on a much smaller scale for staging.

@rushtong
Copy link
Contributor Author

Also, I believe with this promotion, we will also have to upload DAAs, most importantly a Broad DAA to staging consent— there currently are no DAAs uploaded to staging so some of the pages on staging are breaking (DAA Associations, DAR form, etc.). Essentially the work of https://broadworkbench.atlassian.net/browse/DCJ-389 but on a much smaller scale for staging.

For staging, we can add a Dac DAA manually and set up DAA relations for everyone.

@rushtong
Copy link
Contributor Author

I think we need to pull develop into this branch— there's one more PR that got merged that is using the (checkEnv(envGroups.DEV) that we can replace with the DAAUtils.isEnabled() call.

@aarohinadkarni - This is now complete, thank you!

@okotsopoulos okotsopoulos self-requested a review July 18, 2024 13:56
Copy link
Contributor

@okotsopoulos okotsopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Contributor

@aarohinadkarni aarohinadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! 👍

@rushtong rushtong merged commit 8eacafc into develop Jul 18, 2024
9 checks passed
@rushtong rushtong deleted the gr-DCJ-387-promote-to-staging branch July 18, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants