Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: don't require sample-related tables to include a participant ID column #265

Open
mbookman opened this issue Feb 1, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@mbookman
Copy link

mbookman commented Feb 1, 2019

Data Explorer supports samples as an entity separate from participants. However it currently requires all tables related to samples to also include a participant ID.

Much of the time, the source data related to samples does not contain a participant ID, it contains a sample ID. The data design assumption is that there is a mapping table that maps sample IDs to participant IDs.

It is typically not difficult to add a participant id column to the sample-related tables, and it can simplify researchers code if the sample-related tables already include the participant ID, but it would be nice if Data Explorer didn't force this requirement.

@mbookman mbookman added the enhancement New feature or request label Feb 1, 2019
@melissachang
Copy link
Contributor

Note that we're already requiring one change to tables: Add columns with GCS paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants