Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use dataset_id instead of title for dataset summary and file queries (#4273) #4274

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

frano-m
Copy link
Contributor

@frano-m frano-m commented Nov 19, 2024

Ticket

Closes #4273.

Reviewers

@NoopDog.

Changes

  • Updated export "selected filters" for entity related exports to use datasets.dataset_id instead of datasets.title.
  • Current queries panel code is updated to only show the title, and not the selected id.
Example download request:

https://service.anvil.gi.ucsc.edu/fetch/manifest/files?catalog=anvil&filters=%7B%22datasets.dataset_id%22%3A%7B%22is%22%3A%5B%22385290c3-dff5-fb6d-2501-fa0ba3ad1c35%22%5D%7D%2C%22donors.organism_type%22%3A%7B%22is%22%3A%5Bnull%5D%7D%2C%22files.file_format%22%3A%7B%22is%22%3A%5B%22.crai%22%5D%7D%7D&format=verbatim.pfb

Example download payload:
catalog: anvil
filters: {"datasets.dataset_id":{"is":["385290c3-dff5-fb6d-2501-fa0ba3ad1c35"]},"donors.organism_type":{"is":[null]},"files.file_format":{"is":[".crai"]}}
format: verbatim.pfb
image

@frano-m frano-m requested a review from NoopDog November 19, 2024 03:37
@github-actions github-actions bot added the canary Done by the Clever Canary team label Nov 19, 2024
Copy link
Collaborator

@NoopDog NoopDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx! @frano-m

@NoopDog NoopDog merged commit eec90b7 into main Nov 19, 2024
4 checks passed
@frano-m frano-m deleted the fran/4273-export-entity-id branch November 19, 2024 07:39
@frano-m frano-m changed the title feat: use dataset_id instead of title for dataset summary and file queries (#4273) feat!: use dataset_id instead of title for dataset summary and file queries (#4273) Nov 19, 2024
@frano-m frano-m changed the title feat!: use dataset_id instead of title for dataset summary and file queries (#4273) feat: use dataset_id instead of title for dataset summary and file queries (#4273) Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canary Done by the Clever Canary team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AnVIL DX] Use dataset_id instead of title for summary and file queries on dataset export and metadata tabs
2 participants