chore: update findable-ui to v14.0.0 (#4235) #4255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frano-m
commented
Nov 12, 2024
| @@ -25,13 +19,22 @@ export const Announcements = ({ | |||
| return ( | |||
| <Fragment> | |||
| {isSessionTimeout ? ( | |||
| <SessionTimeout onClose={clearSessionTimeout} /> | |||
| <Banner onClose={clearSessionTimeout}> | |||
There was a problem hiding this comment.
Using the generic Banner component and removing unnecessary SessionTimeout, SystemSystem and SystemIndexing components from AnVIL-CMG.
frano-m
commented
Nov 12, 2024
There was a problem hiding this comment.
Alerts and Banners are mostly, now rendered via an MDX file to simplify configuration.
MDX file names are renamed for clarity.
frano-m
commented
Nov 12, 2024
There was a problem hiding this comment.
Alert related functions are renamed, and repositioned due to the rename in viewModelBuilders. Alert related props are passed into the Alert related MDX, along with content (if content is dependent on variables such as authentication).
hunterckx
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #4235.
Reviewers
@hunterckx.
Changes
findable-uitov14.0.0.