Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt-core 1.5.x support #34

Closed
3 tasks
ciklista opened this issue May 25, 2023 · 2 comments
Closed
3 tasks

dbt-core 1.5.x support #34

ciklista opened this issue May 25, 2023 · 2 comments

Comments

@ciklista
Copy link
Contributor

ciklista commented May 25, 2023

Things I found so far that need to be updated to support dbt-core 1.5.0: (I was hoping that #32 would be enough, but it wasn't 😳)

  • the log output of dbt --log-format json ls --output json has changed compared to dbt-core 1.4.x which causes parsing of the result to fail. That should be pretty easy to fix.
  • Are there any other log output changes that need taken care of?
  • dbt-sqlite needs to support dbt-core 1.5.0. Currently it will not run on 1.5.0 which will cause dbt-invoke tests to fail. An issue has been opened on the dbt-sqllite repo (upgrade to support dbt-core v1.5.0 codeforkjeff/dbt-sqlite#43)
17:59:30  Traceback (most recent call last):
  File "/Users/.../code/dbt-invoke/venv_test/lib/python3.11/site-packages/dbt/cli/requires.py", line 86, in wrapper
    result, success = func(*args, **kwargs)
                      ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/../code/dbt-invoke/venv_test/lib/python3.11/site-packages/dbt/cli/requires.py", line 71, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/../code/dbt-invoke/venv_test/lib/python3.11/site-packages/dbt/cli/requires.py", line 142, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/../code/dbt-invoke/venv_test/lib/python3.11/site-packages/dbt/cli/requires.py", line 168, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/../code/dbt-invoke/venv_test/lib/python3.11/site-packages/dbt/cli/requires.py", line 203, in wrapper
    config.credentials.hashed_unique_field()
  File "/Users/.../code/dbt-invoke/venv_test/lib/python3.11/site-packages/dbt/contracts/connection.py", line 144, in hashed_unique_field
    return md5(self.unique_field)
               ^^^^^^^^^^^^^^^^^
  File "/Users/.../code/dbt-invoke/venv_test/lib/python3.11/site-packages/dbt/adapters/sqlite/connections.py", line 40, in unique_field
    return self.host
           ^^^^^^^^^
AttributeError: 'SQLiteCredentials' object has no attribute 'host'
@robastel
Copy link
Member

robastel commented Jun 1, 2023

There doesn't appear to have been movement yet on dbt-sqlite supporting dbt-core 1.5. An alternative option could be to switch to dbt-duckdb.

Another change in dbt-core 1.5.0 that led to problems with dbt-invoke is described by dbt-labs/dbt-core#7465. It appears this will be fixed in dbt-core 1.5.2.

@alexnikitchuk
Copy link

Is there any timeline to fix the issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants