-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.6.4] Regression: Uncaught TypeError: Failed to set the 'currentTime' property on 'HTMLMediaElement' #2326
Comments
Hi @boris-petrov. Could you please let me know which steps are you following to reproduce this issue? Logs from the browser will also help. Thanks! |
@epiclabsDASH - thanks for the answer! Well, we have an integration test that failed. :D We create a DRM version of a video, produce an MPD file, go to the webpage and expect to be able to play the video (using Clearkey encryption). Here's the logs:
I can see this |
Could you please share your sample stream with me? Seems there is an issue when generating the key request and would like to be able to reproduce the issue here. |
We are generating the video with
|
Great, thanks for the info. Could you also share information about how you are instantiating dashjs to open that resource? |
Of course - we use player = videojs videoTag,
controls: true
player.src
src: someSrc
type: someMimeType
keySystemOptions: [
name: 'org.w3.clearkey'
options:
clearkeys: {}
] The options are not exactly like that and the code is a bit more involved but I don't think we do anything funny. Please tell me if you need more information. Thanks! P.S. OK, I think I can see the problem. We're actually doing a P.S.S. OK, I've removed that code and the issue still remains... |
@boris-petrov, unfortunately I can't reproduce the issue here. Could you please send me your sample stream (mpd + video/audio segments)? |
@epiclabsDASH - sure, give me a few days (as I can't do it right now) and I'll attach them here. |
@epiclabsDASH - OK, actually I did it now. :) This ZIP file contains 3 files:
|
@boris-petrov, could you please check if using below version of dash.js fix your issue? Dash.js: http://sedate-join.surge.sh/dist/dash.all.debug.js One question. Are you using ClearKey with a license server or are you directly passing the key and its value in config parameters? |
Thanks for the support! On the question - we are directly passing the parameters, not using a license server. This version got a bit further - there is no "non-finite" stuff but still an error:
|
Just a bit more information with {
message: "Non ASCII: \u0000\u0000\u00004pssh\u0001\u0000\u0000\u0000\u0010w\u00EF\...",
stack: "TypeError: Non ASCII: \u0000\u0000\u00004pssh\u0001\u0000\u0000\u0000\u0010w\u00EF\..."
} @epiclabsDASH - maybe that could help you understand what I'm doing wrong and what made it break after |
That's weird, we didn't change anything related with DRM in v2.6.6. @boris-petrov, what are the values of dataType and initData before when calling session.generateRequest? Any possibility you can share an url that we could use for reproducing and debugging this issue? |
@epiclabsDASH - thanks for the answer! About a URL for debugging - that would be hard I guess. I'll think what I can do but please don't count on it. I'm still using the same files from my previous comments (which are generated with the commands I've given). P.S. I see that in version |
@boris-petrov, could you please at least share the mpd of the stream with me? I am in Slack if you prefer to share it privately. |
@epiclabsDASH - I'm not sure I understand. I uploaded the MPD and the audio/video streams in a previous comment of mine (the one that starts with |
Oh, sorry, my fault |
@boris-petrov, issue should be fixed in #2436. Could you please confirm? |
@epiclabsDASH - I confirm, this pull-request fixes my issue. Thank you for the support! |
Everything was working fine until
2.6.3
. With2.6.4
I'm getting a:This "non-finite" value is coming from this line in StreamController. I don't understand the code at all so I'm not sure whether this is a mistake on my side or really a regression.
Thanks for the hard work on
dash.js
!The text was updated successfully, but these errors were encountered: