-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic player creation cannot be disabled in a non-hacky way #1496
Comments
@bbcrddave - Does window.dashjs = { skipAutoCreate: true }; hack only work when using dash.all.js rather than dash.mediaplayer.js (can't see this referenced in the code). We generally use this when protection and metrics aren't necessary. |
It shouldn't be necessary at all if you are only including dash.mediaplayer.js as the MediaPlayerFactory is only available in dash.all.js. Are you seeing an issue? |
Not seeing an issue with dash.mediaplayer.js, just double-checking my logic that this would be fine. Thanks for confirming. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because no further activity occurred. If you think this issue is still relevant please reopen it. Thank you for your contributions. |
When a
<source>
tag withtype="application/dash.xml"
is found in a page, dash.js will attempt to create a player automatically.This causes a problem for players such as video.js because they use the source tag but expect to control player creation which sometimes ends up creating two players - see #1491 (comment).
There is code which is supposed to disable this
, but it is not clear how this would ever be set. It is not documented anywhereand I'm not sure it would work correctly.We need to either:
a) provide a documented way of disabling automatic player creation
b) remove automatic player creation
#1138 has discussion around this, and appears to have an answer to (a) (#1138 (comment)) but this seems sub-optimal since it requires dash.js specific changes to markup.
Any ideas?
The text was updated successfully, but these errors were encountered: