Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VSTeamJobRequest.ps1 #226

Merged
merged 2 commits into from
Dec 21, 2019
Merged

Conversation

asifma
Copy link
Contributor

@asifma asifma commented Dec 10, 2019

I'm not sure if this is a bug, but I cant find anyway to get jobs that are currently running.
I get these errors because the properties does not exist on a active running build (have also verified using REST API directly):

The property 'result' cannot be found on this object. Verify that the property exists.
At C:\Program Files\WindowsPowerShell\Modules\vsTeam\6.4.1\vsteam.classes.ps1:1331 char:7

  •   $this.Result = $obj.result
    
  •   ~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    • CategoryInfo : NotSpecified: (:) [], PropertyNotFoundException
    • FullyQualifiedErrorId : PropertyNotFoundStrict

Same goes for "finishtime"

So in my pull-request I have included verification to check if property exists.
It's very important and critical for me to get info on how many jobs that are currently running in a pool.

Thanks for this great module!

Best,
Asif

PR Summary

PR Checklist

I'm not sure if this is a bug, but I cant find anyway to get jobs that are currently running.
I get these errors because the properties does not exist on a active running build (have also verified using REST API directly):

The property 'result' cannot be found on this object. Verify that the property exists.
At C:\Program Files\WindowsPowerShell\Modules\vsTeam\6.4.1\vsteam.classes.ps1:1331 char:7
+       $this.Result = $obj.result
+       ~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], PropertyNotFoundException
    + FullyQualifiedErrorId : PropertyNotFoundStrict

Same goes for "finishtime"

So in my pull-request I have included verification to check if property exists.
It's very important and critical for me to get info on how many jobs that are currently running in a pool.

Thanks for this great module! 

Best,
Asif
@DarqueWarrior
Copy link
Collaborator

Sorry for the delay. Thanks for the PR going to work to get it merged ASAP.

@DarqueWarrior DarqueWarrior merged commit 03fa4aa into MethodsAndPractices:master Dec 21, 2019
@asifma asifma deleted the patch-1 branch January 16, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants