Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CMDLET to get work items via WIQL #205

Merged
merged 17 commits into from
Nov 6, 2019
Merged

Added CMDLET to get work items via WIQL #205

merged 17 commits into from
Nov 6, 2019

Conversation

SebastianSchuetze
Copy link
Collaborator

@SebastianSchuetze SebastianSchuetze commented Oct 6, 2019

PR Summary

I added a new cmdlet which was suggested with the issue #175. I had asked some questions regarding some more changes that needed to be made. Since I didn't get an answer yet, I just went with my idea anyways.

So the following things were added:

  • cmdlet Get-VSTeamWiql
    • added an extra parameter "Expand" to the cmdlet to already load all the work items with the given columns in the WIQL command. By default only URL and work item IDs are given
  • added -Team parameter to buildRequestURI and _callAPI because it was not supported by them to have this covered.
  • added a format file for the cmdelet
  • added a type file for the cmdlet

PR Checklist

@SebastianSchuetze SebastianSchuetze changed the title unit test fix Added CMDLET to get work items via WIQL Oct 6, 2019
@SebastianSchuetze
Copy link
Collaborator Author

@DarqueWarrior if my approach with the private functions were correct. Where should I unit test them, if you have some already?

@DarqueWarrior
Copy link
Collaborator

Sorry for delay. I am recovering from surgery. I will get to this ASAP.

@SebastianSchuetze
Copy link
Collaborator Author

NP! Take your time!

@DarqueWarrior
Copy link
Collaborator

Can you sync your repo? Your Build-Module.ps1 is old. The new version runs tests and static code analysis .

@SebastianSchuetze
Copy link
Collaborator Author

@ferwe I gonna improve that. Thanks!

@SebastianSchuetze
Copy link
Collaborator Author

@DarqueWarrior I merged the newest version and also updated the psd and changelog

@SebastianSchuetze SebastianSchuetze marked this pull request as ready for review October 19, 2019 22:39
@DarqueWarrior
Copy link
Collaborator

Just got a break at Ignite. Going to process as many as I can today.

Copy link
Collaborator

@DarqueWarrior DarqueWarrior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.

@DarqueWarrior DarqueWarrior merged commit c5a60da into MethodsAndPractices:master Nov 6, 2019
@SebastianSchuetze SebastianSchuetze deleted the topic/GetWorkItemsByQueryId branch November 7, 2019 08:55
@DarqueWarrior DarqueWarrior mentioned this pull request Nov 7, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants