support for task groups (and a couple other super minor tweaks) #199

quintessential5 · 2019-09-11T02:12:44Z

PR Summary

support for task groups
a typo fix
a minor tweak to my last PR: I didn't _applyTypesToVarGroup on the object returned.
Last PR (support for name when getting var groups) I didn't specifically verify that I could generate the help files. I tried to this time, but received a number of errors. I'm OK to not troubleshoot it further if it generates fine for you, as I don't have any further PR's in mind as of now.

PR Checklist

Write Help
Write Unit Test
~~Update VSTeam.psd1~~ (N/A)
Update CHANGELOG.md

update to support getting by Name.

quintessential5 · 2019-09-12T01:45:42Z

@DarqueWarrior, I'm guessing you already saw the failed job, but figured I'd mention you just in case.

I'm at a loss as to what the issue is. I see this pipeline worked for you on 9/6 (https://loecda.visualstudio.com/Team%20Module/_build/results?buildId=1635&view=results) and the last change was 9/5 (https://github.com/DarqueWarrior/vsteam/commits/master/azure-pipelines.yml), so I'm not sure why it would magically fail now.

Also, it looks like the NuGet and PS versions used in the failing task is the same for your green run (https://loecda.visualstudio.com/3e857acd-880f-4056-a46b-1de672ca55cc/_apis/build/builds/1635/logs/51) as for my red run (https://loecda.visualstudio.com/3e857acd-880f-4056-a46b-1de672ca55cc/_apis/build/builds/1637/logs/42), so no joy there.

I can only think some under the hood AzD change?

DarqueWarrior · 2019-09-15T13:02:53Z

Going to look at it now

DarqueWarrior

Make sure in the help files you have YAML section for all the parameters.
Add description to your examples.
Don't forget your SupportShouldProcess for Remove and Updates and add Force parameters.

.docs/Add-VSTeamTaskGroup.md

.docs/Get-VSTeamTaskGroup.md

Source/Classes/VSTeamVersions.ps1

DarqueWarrior · 2019-09-15T13:22:04Z

Source/Public/Remove-VSTeamTaskGroup.ps1

@@ -0,0 +1,27 @@
+function Remove-VSTeamTaskGroup {
+   [CmdletBinding()]


Add SupportsShouldProcess = $true and a ConfirmImpact value. You can review Remove-VSTeamBuildTag as an example.

DarqueWarrior · 2019-09-15T13:23:12Z

Source/Public/Update-VSTeamTaskGroup.ps1

@@ -0,0 +1,31 @@
+function Update-VSTeamTaskGroup {
+   [CmdletBinding()]


Add SupportsShouldProcess = $true and a ConfirmImpact value. You can review Update-VSTeamBuildDefinition for an example.

Source/Public/Add-VSTeamTaskGroup.ps1

DarqueWarrior · 2019-09-15T13:24:24Z

Source/Public/Update-VSTeamTaskGroup.ps1

+         $resp = _callAPI -Method Put -ProjectName $ProjectName -Area distributedtask -Resource taskgroups -Version $([VSTeamVersions]::TaskGroups) -Body $Body -ContentType 'application/json' -Id $Id   
+      }
+
+      return $resp


Are you missing a call to _applyTypesToVariableGroup?

and return $resp.value rather than $resp.

This reverts commit c4e9d7d.

quintessential5 · 2019-10-03T02:12:35Z

Working on the requested changes.

Should I worry if .docs\gen-help.ps1 has a ton of errors? If it does, does that mean I'm doing something incorrectly? Maybe it's only meant to be run in the AzD build process?

DarqueWarrior · 2019-10-03T19:24:32Z

I have pulled the latest changes and looking around now. Thanks again for the support.

DarqueWarrior · 2019-10-03T19:25:34Z

Working on the requested changes.

Should I worry if .docs\gen-help.ps1 has a ton of errors? If it does, does that mean I'm doing something incorrectly? Maybe it's only meant to be run in the AzD build process?

I just ran it on your master branch and everything worked as expected.

quintessential5 · 2019-10-03T21:58:38Z

Working on the requested changes.
Should I worry if .docs\gen-help.ps1 has a ton of errors? If it does, does that mean I'm doing something incorrectly? Maybe it's only meant to be run in the AzD build process?

I just ran it on your master branch and everything worked as expected.

Weird. In any case, I'm sure you'd let me know if the documentation isn't as you were expecting. Thanks for checking it out!

quintessential5 · 2019-10-03T23:15:10Z

Sorry, I'm realizing that I'm a bit confused as to where we are. I see that you've closed this request rather than merged. I guess you're just planning on looking into the TFS 2017 support, as you mentioned above. You also wrote, "If I determine it is not supported in TFS 2017 we will leave "" and throw when someone tries to use in an unsupported version." I guess you mean in that case, that VSTeam won't support task groups? I guess, in any case, I'll hold off on implementing Force / ShouldProcess for the Remove and Update functions.

quintessential5 · 2019-10-04T00:20:24Z

Sorry, I'm realizing that I'm a bit confused as to where we are. I see that you've closed this request rather than merged. I guess you're just planning on looking into the TFS 2017 support, as you mentioned above. You also wrote, "If I determine it is not supported in TFS 2017 we will leave "" and throw when someone tries to use in an unsupported version." I guess you mean in that case, that VSTeam won't support task groups? I guess, in any case, I'll hold off on implementing Force / ShouldProcess for the Remove and Update functions.

Correction: looks like I had already implemented Force / ShouldProcess. I'm now just fixing some unit tests in my environment-specific wrapper module to make sure my implementation is OK. I guess I should make a new pull request for that?

quintessential5 · 2019-10-04T00:34:28Z

@DarqueWarrior, no rush at all. Just making sure you saw the above comments so we don't duplicate effort on Force / ShouldProcess. I'm guessing maybe GitHub doesn't notify you on my comments to my own PR?

DarqueWarrior · 2019-10-04T00:35:26Z

Can you make sure I have commit permissions to this PR.

quintessential5 · 2019-10-04T00:37:21Z

Can you make sure I have commit permissions to this PR.

Googling how to set that up...

quintessential5 · 2019-10-04T00:41:41Z

Can you make sure I have commit permissions to this PR.

Googling how to set that up...

Done.

DarqueWarrior · 2019-10-04T00:42:32Z

I made several changes and updated the formats for you. I think I could be able to merge the changes when you re-open it.

quintessential5 · 2019-10-04T00:44:46Z

Super weird: I've clicked the checkbox below multiple times, and it appears to take effect, but if I refresh the page, it reverts to being unchecked:

quintessential5 · 2019-10-04T00:45:50Z

I also don't see an obvious way to re-open:

Maybe since you closed it, I don't have permission to re-open? Maybe once it's re-opened the permission to let you commit will stick?

quintessential5 · 2019-10-04T01:09:40Z

Yeah, I see that there should be a "Reopen pull request" button:

... that I don't have:

... so, I'm guessing you have the power :)

quintessential5 · 2019-10-04T15:53:05Z

@DarqueWarrior, no rush at all, just for clarity: just let me know if you can't re-open this PR (which I'm hoping will let us fix your ability to commit to it). If you can't re-open, I'll just make a new PR.

quintessential5 and others added 15 commits August 28, 2019 19:59

Get-VSTeamVariableGroup: support for get by name

7c9c281

Merge remote-tracking branch 'upstream/master'

4116b7b

Format changes.

4da5662

merge from upstream

3680f7e

Help published

ace381a

typo fix

1ed2c4c

missed applyTypesToVarGroup in get var group...

a57bbd7

update to support getting by Name.

pipeline changes: merge from upstream

583b39b

Get-VSTeamTaskGroup

13880b3

Get task group: added param attributes

23bd616

Add-VSTeamTaskGroup and unit tests

695e77c

Update-VSTeamTaskGroup and tests

97249cd

Remove-VSTeamTaskGroup

c80b730

Merge remote-tracking branch 'upstream/master'

6912442

documentation for task groups (& minor tweak)

2574252

DarqueWarrior reviewed Sep 15, 2019

View reviewed changes

quintessential5 added 2 commits September 30, 2019 19:10

var groups: only support Body param (for now)...

c4e9d7d

and return $resp.value rather than $resp.

Revert "var groups: only support Body param (for now)..."

b941396

This reverts commit c4e9d7d.

requested documentation changes

0cec860

DarqueWarrior closed this Oct 3, 2019

quintessential5 mentioned this pull request Oct 21, 2019

Support for Task Groups #212

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support for task groups (and a couple other super minor tweaks) #199

support for task groups (and a couple other super minor tweaks) #199

quintessential5 commented Sep 11, 2019

quintessential5 commented Sep 12, 2019 •

edited

Loading

DarqueWarrior commented Sep 15, 2019

DarqueWarrior left a comment

DarqueWarrior Sep 15, 2019

DarqueWarrior Sep 15, 2019

DarqueWarrior Sep 15, 2019

quintessential5 commented Oct 3, 2019

DarqueWarrior commented Oct 3, 2019

DarqueWarrior commented Oct 3, 2019 •

edited

Loading

quintessential5 commented Oct 3, 2019

quintessential5 commented Oct 3, 2019 •

edited

Loading

quintessential5 commented Oct 4, 2019

quintessential5 commented Oct 4, 2019

DarqueWarrior commented Oct 4, 2019

quintessential5 commented Oct 4, 2019

quintessential5 commented Oct 4, 2019

DarqueWarrior commented Oct 4, 2019

quintessential5 commented Oct 4, 2019

quintessential5 commented Oct 4, 2019

quintessential5 commented Oct 4, 2019

quintessential5 commented Oct 4, 2019

		@@ -0,0 +1,27 @@
		function Remove-VSTeamTaskGroup {
		[CmdletBinding()]

		@@ -0,0 +1,31 @@
		function Update-VSTeamTaskGroup {
		[CmdletBinding()]

support for task groups (and a couple other super minor tweaks) #199

support for task groups (and a couple other super minor tweaks) #199

Conversation

quintessential5 commented Sep 11, 2019

PR Summary

PR Checklist

quintessential5 commented Sep 12, 2019 • edited Loading

DarqueWarrior commented Sep 15, 2019

DarqueWarrior left a comment

Choose a reason for hiding this comment

DarqueWarrior Sep 15, 2019

Choose a reason for hiding this comment

DarqueWarrior Sep 15, 2019

Choose a reason for hiding this comment

DarqueWarrior Sep 15, 2019

Choose a reason for hiding this comment

quintessential5 commented Oct 3, 2019

DarqueWarrior commented Oct 3, 2019

DarqueWarrior commented Oct 3, 2019 • edited Loading

quintessential5 commented Oct 3, 2019

quintessential5 commented Oct 3, 2019 • edited Loading

quintessential5 commented Oct 4, 2019

quintessential5 commented Oct 4, 2019

DarqueWarrior commented Oct 4, 2019

quintessential5 commented Oct 4, 2019

quintessential5 commented Oct 4, 2019

DarqueWarrior commented Oct 4, 2019

quintessential5 commented Oct 4, 2019

quintessential5 commented Oct 4, 2019

quintessential5 commented Oct 4, 2019

quintessential5 commented Oct 4, 2019

quintessential5 commented Sep 12, 2019 •

edited

Loading

DarqueWarrior commented Oct 3, 2019 •

edited

Loading

quintessential5 commented Oct 3, 2019 •

edited

Loading