Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(email_sender): add max size to the attachments #13

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

JRocabruna
Copy link
Member

@JRocabruna JRocabruna commented Jun 4, 2024

Feature/Implement Maximum Attachment Size for Email Messages

Description

This pull request introduces a new feature that allows setting a maximum size for attachments in EmailMessage instances within the gomail package. The feature includes:

  • A default maximum attachment size of 25 MB.
  • A method to set a custom maximum attachment size.
  • Logic to exclude attachments that exceed the specified maximum size during the email sending process.
  • Comprehensive updates to the documentation to describe the new feature and provide instructions on its usage.

This enhancement improves the usability and reliability of the gomail package by preventing large attachments from causing email delivery failures. It aligns with best practices for email transmission and assists users in avoiding common issues.

Checklist

Please ensure the following guidelines are met:

  • The code follows the style guidelines of this project.
  • A self-review has been performed on the code.
  • The code is well-documented, and comments have been added where necessary.
  • Tests have been added to prove that the fix is effective or that the feature works. All existing tests pass.
  • Commit messages follow the convention type(scope): description.
  • The pull request has no conflicts with the base branch.
  • Any dependent changes have been merged and published in downstream modules.

Additional Information

This feature will enhance the usability and reliability of the gomail package by preventing large attachments from causing email delivery failures. The implementation includes comprehensive tests to ensure the feature works as intended and does not introduce regressions. The documentation has been updated to reflect these changes and provide guidance on using the new functionality.

@JRocabruna JRocabruna changed the base branch from main to develop June 4, 2024 23:04
@JRocabruna JRocabruna self-assigned this Jun 4, 2024
@JRocabruna JRocabruna added enhancement New feature or request refactoring Code refactoring to improve structure without changing functionality. performance Improvements related to the efficiency and speed of the code. labels Jun 4, 2024
DarkRockMountain-admin

This comment was marked as duplicate.

@JRocabruna JRocabruna dismissed DarkRockMountain-admin’s stale review June 4, 2024 23:12

The merge-base changed after approval.

DarkRockMountain-admin

This comment was marked as duplicate.

DarkRockMountain-admin

This comment was marked as duplicate.

@DarkRockMountain-admin DarkRockMountain-admin dismissed their stale review June 4, 2024 23:14

The merge-base changed after approval.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Collaborator

@DarkRockMountain-admin DarkRockMountain-admin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments

The addition of the maximum attachment size feature provides a useful constraint to prevent issues with large email attachments, ensuring compatibility with email provider limits. The default size and the ability to set a custom size add flexibility for users. Documentation and tests have been updated to reflect these changes.

Review Checklist

  • Code adheres to the project's coding guidelines.
  • Changes are well-documented.
  • Tests have been added/updated and pass successfully.
  • Commit messages follow the correct format: type(scope): description.
  • No conflicts with the base branch.

Approval

Approved: Changes look good and meet the project's contribution standards.

@DarkRockMountain-admin DarkRockMountain-admin merged commit 5fe6886 into develop Jun 4, 2024
8 checks passed
@DarkRockMountain-admin DarkRockMountain-admin deleted the feature/add-max-attachment-size branch June 4, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance Improvements related to the efficiency and speed of the code. refactoring Code refactoring to improve structure without changing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] - Implement Maximum Attachment Size for Email Messages
3 participants