Fix +/-inf in LSE returned by forward #978
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward op was returning
+inf
in LSE for queries which have no keys to attend to, e.g. when K/V length happens to be 0. This diverges from the definition ofLSE = log(exp(L1) + ... exp(L2))
which would givelog(0) = -inf
.This PR fixes it, which allows feeding the output LSE directly into ops like merge_attentions without postprocessing.