Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows actions #1036

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Windows actions #1036

wants to merge 11 commits into from

Conversation

bdashore3
Copy link

Hi all,

I've been maintaining a fork with Windows wheels for the past ~9 months. Thanks to @jllllll for the initial action that I worked off of. It's been known that Windows is supported by Flash-attention 2 due to the existence of these wheels and various commits that have fixed Windows builds in the past.

As such, I'd like to get these actions working in the official repo so windows wheels can be available when installing via pip and actions will trigger per-release.

I've currently published the actions that do build wheels, but they'll need editing to support being triggered on release and publishing to pypi via twine. I'm not familiar with twine, so I'll need some help there if possible.

cc: @tridao

jllllll and others added 11 commits July 9, 2024 09:50
We only build wheels for cuda 12

Signed-off-by: kingbri <[email protected]>
Builds fail without it.

Signed-off-by: kingbri <[email protected]>
Build for 2.2.2 and 2.3.0

Signed-off-by: kingbri <[email protected]>
Adds python 3.12 support and fixes MSVC issues with the Windows-2022
image

Signed-off-by: kingbri <[email protected]>
Used to use a non-existent variable.

Signed-off-by: kingbri <[email protected]>
Not used anyways.

Signed-off-by: kingbri <[email protected]>
@umarbutler
Copy link

Is this ready to merge? If so, @tridao can we get this merged?

@Ratinod
Copy link

Ratinod commented Nov 1, 2024

I give up... I can't get flash-attention to compile... Can we get official support for Windows wheels? @tridao Please...

@bdashore3
Copy link
Author

bdashore3 commented Nov 3, 2024

I have windows releases located here in my fork. These should work. If you still want to build yourself, consider referencing the actions YML here

However, since building with backward/dropout maxes out the time for a Github action (6 hours), the build does not include these features and requires a self-compile if you want to train with FA2 on Windows.

It seems like this repo is all-in on FA3 now since there hasn't been a release in some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants