get-attribute.js now supports single quotes

DanielJDufour · Apr 7, 2023 · 99616dd · 99616dd
1 parent 689b525
commit 99616dd
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/get-attribute.js b/get-attribute.js
@@ -7,13 +7,17 @@ function getAttribute(tag, attributeName, options) {
   // only search for attributes in the opening tag
   const opening = xml.slice(0, xml.indexOf(">") + 1);
 
-  const pattern = `${attributeName}\\="\([^"]*\)"`;
-  if (debug) console.log("[xml-utils] pattern:", pattern);
+  const quotechars = ['"', "'"];
+  for (let i = 0; i < quotechars.length; i++) {
+    const char = quotechars[i];
+    const pattern = attributeName + "\\=" + char + "([^" + char + "]*)" + char;
+    if (debug) console.log("[xml-utils] pattern:", pattern);
 
-  const re = new RegExp(pattern);
-  const match = re.exec(opening);
-  if (debug) console.log("[xml-utils] match:", match);
-  if (match) return match[1];
+    const re = new RegExp(pattern);
+    const match = re.exec(opening);
+    if (debug) console.log("[xml-utils] match:", match);
+    if (match) return match[1];
+  }
 }
 
 module.exports = getAttribute;

diff --git a/test/test.js b/test/test.js
@@ -195,3 +195,7 @@ test("should handle nested tags", ({ eq }) => {
   ]);
   eq(findTagByPath(xml, ["Thing"]).outer, xml);
 });
+
+test("getAttribute with single quotes", ({ eq }) => {
+  eq(getAttribute("<link href='https://example.org'/>", "href"), "https://example.org");
+});