fixed bug in get-attribute

DanielJDufour · Jul 25, 2020 · 1e9b88d · 1e9b88d
1 parent 12e1d21
commit 1e9b88d
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "xml-utils",
-  "version": "0.1.0",
+  "version": "0.2.0",
   "description": "Parse XML without Blowing Up Your Bundle Size",
   "main": "src/index.js",
   "scripts": {

diff --git a/src/get-attribute.js b/src/get-attribute.js
@@ -4,11 +4,12 @@ function getAttribute(tag, attributeName, options) {
 
   const xml = typeof tag === "object" ? tag.outer : tag;
 
-  const pattern = `${attributeName}\\="\(.*\)"`;
+  const pattern = `${attributeName}\\="\([^"]*\)"`;
   if (debug) console.log("pattern:", pattern);
 
   const re = new RegExp(pattern);
   const match = re.exec(xml);
+  if (debug) console.log("match:", match);
   if (match) return match[1];
 }
 

diff --git a/test/test.js b/test/test.js
@@ -68,4 +68,10 @@ describe('getAttribute', function() {
     const key = getAttribute(mdi, 'key', { debug: false });
     expect(key).to.equal('SourceBandIndex');
   });
+  it("should get raster width from a .mrf file", function() {
+    const rasterSize = '<Size x="6638" y="7587" c="4" />';
+    expect(getAttribute(rasterSize, 'x')).to.equal("6638");
+    expect(getAttribute(rasterSize, 'y')).to.equal("7587");
+    expect(getAttribute(rasterSize, 'c')).to.equal("4");
+  });
 });