Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chart/redis-ha][REQUEST] Support custom pod annotations on the service-test pod #304

Open
bengadbois opened this issue Nov 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@bengadbois
Copy link

Is your feature request related to a problem? Please describe.
The redis-ha test pod doesn't support custom pod annotations. For certain environments that may be needed.

Describe the solution you'd like
Most of the other deployments/statefulsets in redis-ha support the custom annotations, via .Values.podAnnotations. It would be useful to let the redis-ha test pod to also get custom annotations in a similar way.

Describe alternatives you've considered
My workaround until a fix is merged/released is to patch the test pod's .metadata.annotations. Somewhat inelegant, but works.

Additional context
The one potential risk here is users who previously set podAnnotations in their helm chart may be surprised when that annotation which previously didn't get set on the test pod now does. Since it's an annotation, not a label, it seems likely to introduce selector-based bugs like accidentally getting included as a target in a PDB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant