-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking: Revert #5102 when possible #5213
Tracking: Revert #5102 when possible #5213
Comments
Can we revert after the next npm release or we are going to wait till the major release? |
The plan is to release in v6 and remove again in v7 to give people time to upgrade their dependencies. |
@jasnell |
@ChALkeR do you know how many modules rely on the pre fix version? |
@thealphanerd Uh-oh. Not yet. For now, I can check only direct dependants. Note that v4.x are fixed, v3.x and below are affected, so I excluded everything that works with 4.x. Update: |
@thealphanerd I will check indirect deps too, but I can't say when yet. |
More modules that directly use
Update: All of the above looks like they are being polluted by |
@thealphanerd Indirect deps seem to be huge. |
PR #5102 was landed as a temporary measure to get npm in master working again. This issue is intended to serve as a reminder that it needs to be reverted as planned.
/cc @ChALkeR @thealphanerd @nodejs/ctc
The text was updated successfully, but these errors were encountered: