From f2334b31bb1c353beb9e610e270b39a9cf30e7f4 Mon Sep 17 00:00:00 2001 From: Damian Krolik Date: Wed, 15 Jun 2022 10:28:49 +0200 Subject: [PATCH] [nrf noup] Use "continue-on-error" for examples in CI Make building nRF Connect examples optional in github workflows in a sense that they do not fail the workflow if they do not compile. The reason is that the CI is often run for downstream patches, that are required to proceed with changes in NCS or Zephyr and we do not want to force developers to update examples in sdk-connectedhomeip at that moment - they will be updated in the upstream later. Signed-off-by: Damian Krolik --- .github/workflows/examples-nrfconnect.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.github/workflows/examples-nrfconnect.yaml b/.github/workflows/examples-nrfconnect.yaml index 3c110ce1ccece7..8bd542ed990cbc 100644 --- a/.github/workflows/examples-nrfconnect.yaml +++ b/.github/workflows/examples-nrfconnect.yaml @@ -83,11 +83,13 @@ jobs: - name: Update nRF Connect SDK revision to the currently recommended. timeout-minutes: 15 run: scripts/run_in_build_env.sh "python3 scripts/setup/nrfconnect/update_ncs.py --update --shallow" + continue-on-error: true - name: Run unit tests of factory data generation script timeout-minutes: 15 run: scripts/run_in_build_env.sh "./scripts/tools/nrfconnect/tests/test_generate_factory_data.py" - name: Build example nRF Connect SDK Lock App on nRF52840 DK if: github.event_name == 'push' || steps.changed_paths.outputs.nrfconnect == 'true' + continue-on-error: true timeout-minutes: 15 run: | scripts/examples/nrfconnect_example.sh lock-app nrf52840dk_nrf52840 @@ -97,6 +99,7 @@ jobs: /tmp/bloat_reports/ - name: Build example nRF Connect SDK Lighting App on nRF52840 DK if: github.event_name == 'push' || steps.changed_paths.outputs.nrfconnect == 'true' + continue-on-error: true timeout-minutes: 15 run: | scripts/examples/nrfconnect_example.sh lighting-app nrf52840dk_nrf52840 @@ -106,6 +109,7 @@ jobs: /tmp/bloat_reports/ - name: Build example nRF Connect SDK Lighting App on nRF52840 Dongle if: github.event_name == 'push' || steps.changed_paths.outputs.nrfconnect == 'true' + continue-on-error: true timeout-minutes: 15 run: | scripts/examples/nrfconnect_example.sh lighting-app nrf52840dongle_nrf52840 -DCONF_FILE=prj_no_dfu.conf -DCONFIG_CHIP_ROTATING_DEVICE_ID=y @@ -115,6 +119,7 @@ jobs: /tmp/bloat_reports/ - name: Build example nRF Connect SDK Lighting App on nRF52840 DK with RPC if: github.event_name == 'push' || steps.changed_paths.outputs.nrfconnect == 'true' + continue-on-error: true timeout-minutes: 20 run: | scripts/examples/nrfconnect_example.sh lighting-app nrf52840dk_nrf52840 -DOVERLAY_CONFIG=rpc.overlay @@ -124,6 +129,7 @@ jobs: /tmp/bloat_reports/ - name: Build example nRF Connect SDK Shell on nRF52840 DK if: github.event_name == 'push' || steps.changed_paths.outputs.shell == 'true' + continue-on-error: true timeout-minutes: 15 run: | scripts/examples/nrfconnect_example.sh shell nrf52840dk_nrf52840 @@ -133,6 +139,7 @@ jobs: /tmp/bloat_reports/ - name: Build example nRF Connect SDK Pigweed on nRF52840 DK if: github.event_name == 'push' || steps.changed_paths.outputs.pigweed-app == 'true' + continue-on-error: true timeout-minutes: 15 run: | scripts/examples/nrfconnect_example.sh pigweed-app nrf52840dk_nrf52840 @@ -142,6 +149,7 @@ jobs: /tmp/bloat_reports/ - name: Build example nRF Connect SDK Lock App on nRF5340 DK if: github.event_name == 'push' || steps.changed_paths.outputs.nrfconnect == 'true' + continue-on-error: true timeout-minutes: 15 run: | scripts/examples/nrfconnect_example.sh lock-app nrf5340dk_nrf5340_cpuapp @@ -151,6 +159,7 @@ jobs: /tmp/bloat_reports/ - name: Build example nRF Connect SDK Lighting App on nRF5340 DK if: github.event_name == 'push' || steps.changed_paths.outputs.nrfconnect == 'true' + continue-on-error: true timeout-minutes: 15 run: | scripts/examples/nrfconnect_example.sh lighting-app nrf5340dk_nrf5340_cpuapp @@ -160,6 +169,7 @@ jobs: /tmp/bloat_reports/ - name: Build example nRF Connect SDK Pump App on nRF52840 DK if: github.event_name == 'push' || steps.changed_paths.outputs.nrfconnect == 'true' + continue-on-error: true timeout-minutes: 15 run: | scripts/examples/nrfconnect_example.sh pump-app nrf52840dk_nrf52840 @@ -169,6 +179,7 @@ jobs: /tmp/bloat_reports/ - name: Build example nRF Connect SDK Pump Controller App on nRF52840 DK if: github.event_name == 'push' || steps.changed_paths.outputs.nrfconnect == 'true' + continue-on-error: true timeout-minutes: 15 run: | scripts/examples/nrfconnect_example.sh pump-controller-app nrf52840dk_nrf52840 @@ -177,6 +188,7 @@ jobs: examples/pump-controller-app/nrfconnect/build/zephyr/zephyr.elf \ /tmp/bloat_reports/ - name: Build example nRF Connect SDK All Clusters App on nRF52840 DK + continue-on-error: true timeout-minutes: 20 run: | scripts/examples/nrfconnect_example.sh all-clusters-app nrf52840dk_nrf52840 -DCONF_FILE=prj_dfu.conf