Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Can't change welcome page in editor in latest version #760

Closed
oliexe opened this issue Jun 8, 2022 · 4 comments · Fixed by #778
Closed

bug: Can't change welcome page in editor in latest version #760

oliexe opened this issue Jun 8, 2022 · 4 comments · Fixed by #778
Assignees
Labels
bug Something isn't working

Comments

@oliexe
Copy link

oliexe commented Jun 8, 2022

/**
     * The welcome page of editor bench
     */
    entry?: React.ReactNode;

Specifying entry in EditorView does not change the welcome screen in 0.9.0-beta.4.2.
This was functional in previous versions.

@oliexe oliexe added the bug Something isn't working label Jun 8, 2022
@wewoor
Copy link
Collaborator

wewoor commented Jun 8, 2022

@oliexe Thanks for your feedback

@mortalYoung mortalYoung mentioned this issue Jun 22, 2022
13 tasks
@mortalYoung
Copy link
Collaborator

Hi. Would you mind upgrade to v1.0.2 and check whether this problem still exist.

@oliexe
Copy link
Author

oliexe commented Jun 29, 2022

@mortalYoung
This is still not functional in 1.0.2

@mortalYoung
Copy link
Collaborator

To be honest, I couldn't find the reason why this was still not functional in 1.0.2 until I realized the difference between React.ReactNode and JSX.Element.

I guessed the reason must be incorrect usage.

It should be used like:

molecule.editor.setEntry(<YourComponent />)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants