Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error browsing by title, date, or subject category in a community/collection #3840

Closed
toniprieto opened this issue Jan 13, 2025 · 3 comments · Fixed by #3845
Closed

Error browsing by title, date, or subject category in a community/collection #3840

toniprieto opened this issue Jan 13, 2025 · 3 comments · Fixed by #3845
Assignees
Labels
bug component: Discovery related to discovery search or browse system high priority
Milestone

Comments

@toniprieto
Copy link
Contributor

toniprieto commented Jan 13, 2025

Describe the bug

The current branch (and I assume also the dspace-8x and dspace-7x branches) has an error in browsing by title, date, or subject category when navigating within a community or collection. Browsing at the site level works correctly.

To Reproduce

Steps to reproduce the behavior:

  1. Go to a community or collection with items: https://demo.dspace.org/communities/0958c910-2037-42a9-81c7-dca80e3892b4
  2. Attempt to browse by title: https://demo.dspace.org/communities/0958c910-2037-42a9-81c7-dca80e3892b4/browse/title
  3. An error is displayed.

I think the issue occurs because the UI is sending incorrect requests to the REST API. For these types of indices, it should send requests like:

http://localhost:8080/server/api/discover/browses/dateissued/items?scope=258d5d37-0fab-47e8-865c-26f025864622&sort=default,ASC&page=0&size=20

But instead, it is sending requests like:

http://localhost:8080/server/api/discover/browses/dateissued/entries?scope=258d5d37-0fab-47e8-865c-26f025864622&sort=default,ASC&page=0&size=20

Related work

I think it may be related to the changes introduced in #3753. If I revert the commit from this PR, browsing works again.

@toniprieto toniprieto added bug needs triage New issue needs triage and/or scheduling labels Jan 13, 2025
@toniprieto
Copy link
Contributor Author

toniprieto commented Jan 13, 2025

Hi @jensvannerum , Could you take a look at this issue? I think it might be related to the changes in #3753 , and perhaps you have a possible solution. Thank you!

@tdonohue tdonohue added high priority component: Discovery related to discovery search or browse system and removed needs triage New issue needs triage and/or scheduling labels Jan 13, 2025
@tdonohue
Copy link
Member

@jensvannerum : Could you take a look at this? It appears to be caused by #3753, which was recently merged.

(I'm also moving this ticket to the frontend, as it looks like a frontend bug.)

@jensvannerum
Copy link
Contributor

Hi, thanks for catching this.

In my initial PR i didn't consider to update the scoped pages too, it's fixed now in linked PR which applies the same logic as my previous PR in the scoped pages too

@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 9.0 Release Jan 16, 2025
@tdonohue tdonohue added this to the 7.6.3 milestone Jan 16, 2025
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in DSpace 9.0 Release Jan 17, 2025
@tdonohue tdonohue modified the milestones: 7.6.3, 8.1 Jan 17, 2025
@tdonohue tdonohue moved this from 📋 To Do to ✅ Done in DSpace 8.x and 7.6.x Maintenance Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component: Discovery related to discovery search or browse system high priority
Projects
Development

Successfully merging a pull request may close this issue.

3 participants