-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade @ngrx #126
Comments
I'd rather upgrade to @ngrx/platform as soon as possible. The ngrx team has been closing a quite a few issues I was watching with the notification that they're fixed in platform. Ngrx-store-freeze is just a tool that ensures objects stay immutable during development. I say we leave store-freeze out now, and create an issue to put it back in as soon as it's up to date |
Hey @artlowel the store-freeze tool is up to date with ngrx v4 now. |
Thanks for the heads up. adding ngrx-store-freeze back in is trivial. But I can't seem to figure out an AoT compatible way to determine whether we're in production mode, in order to decide whether or not to add ngrx-store-freeze to AppModule's imports. I've tried all sorts of things, using it directly, using the getConfig() function, wrapping the imports in another function, wrapping the entire initialization of ENV_CONFIG in config.ts in a function … I keep running in to the @wellingWilliam can you have a look? You can find my current, broken branch here |
@artlowel I will try to make some time to look at this later today or tomorrow. |
This upgrade is complete. Closing now. |
[DSC-473] Wrong 'dc.date.issue' format causes loader to be shown indefinitely in "Browsing by issue date" page Approved-by: Giuseppe Digilio
This will have to wait until brandonroberts/ngrx-store-freeze#17 is resolved.
The text was updated successfully, but these errors were encountered: