Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @ngrx #126

Closed
ghost opened this issue Jul 19, 2017 · 5 comments
Closed

Upgrade @ngrx #126

ghost opened this issue Jul 19, 2017 · 5 comments

Comments

@ghost
Copy link

ghost commented Jul 19, 2017

This will have to wait until brandonroberts/ngrx-store-freeze#17 is resolved.

@artlowel
Copy link
Member

I'd rather upgrade to @ngrx/platform as soon as possible. The ngrx team has been closing a quite a few issues I was watching with the notification that they're fixed in platform.

Ngrx-store-freeze is just a tool that ensures objects stay immutable during development.
if you write a reducer, you should write tests for that immutablility anyway
ngrx-store-freeze just makes it easier to detect those issues early.

I say we leave store-freeze out now, and create an issue to put it back in as soon as it's up to date

@artlowel artlowel added the ready label Aug 17, 2017
@sliekens
Copy link

Hey @artlowel the store-freeze tool is up to date with ngrx v4 now.

@artlowel
Copy link
Member

Thanks for the heads up.

adding ngrx-store-freeze back in is trivial. But I can't seem to figure out an AoT compatible way to determine whether we're in production mode, in order to decide whether or not to add ngrx-store-freeze to AppModule's imports.

I've tried all sorts of things, using it directly, using the getConfig() function, wrapping the imports in another function, wrapping the entire initialization of ENV_CONFIG in config.ts in a function … I keep running in to the Error encountered resolving symbol values statically error

@wellingWilliam can you have a look? You can find my current, broken branch here

@ghost
Copy link
Author

ghost commented Sep 25, 2017

@artlowel I will try to make some time to look at this later today or tomorrow.

@ghost ghost added needs review and removed ready labels Sep 27, 2017
@ghost ghost mentioned this issue Sep 29, 2017
@ghost
Copy link
Author

ghost commented Oct 2, 2017

This upgrade is complete. Closing now.

@ghost ghost closed this as completed Oct 2, 2017
@ghost ghost removed the needs review label Oct 2, 2017
4science-it pushed a commit to 4Science/dspace-angular that referenced this issue Feb 22, 2022
[DSC-473] Wrong 'dc.date.issue' format causes loader to be shown indefinitely in "Browsing by issue date" page

Approved-by: Giuseppe Digilio
kosarko pushed a commit to ufal/dspace-angular that referenced this issue May 11, 2023
kosarko pushed a commit to ufal/dspace-angular that referenced this issue Jun 20, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants