Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P25 FQSUID Handling Improvments #1977

Closed
DSheirer opened this issue Sep 10, 2024 · 0 comments · Fixed by #1978
Closed

P25 FQSUID Handling Improvments #1977

DSheirer opened this issue Sep 10, 2024 · 0 comments · Fixed by #1978
Assignees
Labels
Milestone

Comments

@DSheirer
Copy link
Owner

DSheirer commented Sep 10, 2024

Recent changes #1975 & #1966 result in Fully Qualified source identifiers not being embeded into the recording files.

The default behavior for radio identifiers with a value of zero is to flag them as invalid. Sinc FQSUID extends this class, it inherits this behavior and thus the identifiers were being ignored.

Override the isValid() method for FQSUID and FQTGID to ensure that ISSI patch values don't get flagged as invalid.

@DSheirer DSheirer added the bug label Sep 10, 2024
@DSheirer DSheirer self-assigned this Sep 10, 2024
@DSheirer DSheirer added this to the Version 0.6.1 milestone Sep 10, 2024
DSheirer pushed a commit that referenced this issue Sep 14, 2024
DSheirer pushed a commit that referenced this issue Sep 14, 2024
…kgroup identifiers we're being flagged as invalid when ISSI patch assigned a local address/ID of zero. Changes format of FQSUID and FQTGID to use a value of zero for the local alias when the call type is an ISSI patch and suppress display of the 0 alias value. If the identifier represents a roaming user, then the local address value is displayed with the FQSUID appended in parenthesis.
@DSheirer DSheirer changed the title Revert P25 Fully Qualified Identifiers Changes P25 FQSUID Handling Improvments Sep 14, 2024
DSheirer added a commit that referenced this issue Sep 15, 2024
…kgroup identifiers we're being flagged as invalid when ISSI patch assigned a local address/ID of zero. Changes format of FQSUID and FQTGID to use a value of zero for the local alias when the call type is an ISSI patch and suppress display of the 0 alias value. If the identifier represents a roaming user, then the local address value is displayed with the FQSUID appended in parenthesis. (#1978)

Co-authored-by: Dennis Sheirer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant