Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Winget doesn't add dlp-cli path directly #949

Open
dwu359 opened this issue Sep 8, 2023 · 3 comments
Open

[BUG]: Winget doesn't add dlp-cli path directly #949

dwu359 opened this issue Sep 8, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@dwu359
Copy link
Contributor

dwu359 commented Sep 8, 2023

Operating system

Windows

Bug description

This happened during pair prog on 9/7 on @Dashrekker's computer. @Dashrekker tried to install the dlp-cli with this cmd from the dlp-cli README (after init of dlp-cli submodule): winget install -m dlp-cli/manifests/d/DSGT-DLP/dlp-cli/0.0.11. Winget does install the dlp-cli, but it doesn't add the path properly to environment variables. @Dashrekker was able to resolve this by adding the path to the dlp-cli.exe manually to the path env var.

This seems like this is a current issue that winget is resolving: microsoft/winget-cli#3002

What we can do ig is that we'll just have to modify the README stating the path env var to the winget installation location of dlp-cli that would need to be added for now.

Steps to reproduce

Follow the Windows installation instructions in the dlp-cli README

@dwu359 dwu359 added the bug Something isn't working label Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Hello @dwu359! Thank you for submitting the Bug Request Form. We appreciate your contribution. 👋

We will look into it and provide a response as soon as possible.

To work on this bug request, you can follow these branch setup instructions:

  1. Checkout the main branch:
```
 git checkout nextjs
```
  1. Pull the latest changes from the remote main branch:
```
 git pull origin nextjs
```
  1. Create a new branch specific to this bug request using the issue number:
    git checkout -b bug-949

Feel free to make the necessary changes in this branch and submit a pull request when you're ready.

Best regards,
Deep Learning Playground (DLP) Team

@karkir0003
Copy link
Member

@dwu359 noah also resolved this?

@karkir0003
Copy link
Member

@dwu359 can this task be marked as deprioritized since we have scoop for windows install of dlp-cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

2 participants