-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create a backend to parse USPTO patents into DoclingDocument #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 Require two reviewer for test updatesWonderful, this rule succeeded.When test data is updated, we require two reviewers
|
3 tasks
ceberam
force-pushed
the
dev/xml-uspto
branch
from
December 17, 2024 10:36
122db98
to
174e7d8
Compare
ceberam
requested review from
PeterStaar-IBM,
dolfim-ibm and
cau-git
and removed request for
PeterStaar-IBM and
dolfim-ibm
December 17, 2024 13:06
ceberam
force-pushed
the
dev/xml-uspto
branch
from
December 17, 2024 13:30
dcfb2ae
to
fe96c11
Compare
Signed-off-by: Cesar Berrospi Ramis <[email protected]>
Add a backend implementation to parse patent applications and grants from the United States Patent Office (USPTO). Signed-off-by: Cesar Berrospi Ramis <[email protected]>
Change the name of the patent USPTO input format to show the typical format (XML). Signed-off-by: Cesar Berrospi Ramis <[email protected]>
Signed-off-by: Cesar Berrospi Ramis <[email protected]>
ceberam
force-pushed
the
dev/xml-uspto
branch
from
December 17, 2024 13:39
fe96c11
to
3d249eb
Compare
Signed-off-by: Cesar Berrospi Ramis <[email protected]>
Signed-off-by: Cesar Berrospi Ramis <[email protected]>
ceberam
force-pushed
the
dev/xml-uspto
branch
from
December 17, 2024 14:39
3d249eb
to
94735ec
Compare
dolfim-ibm
approved these changes
Dec 17, 2024
cau-git
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #605
This PR implements the following changes:
docling/datamodel/document.py
to address the scenario of multipleInputFormat
instances with the same mime type. In particular, add a function that further examines part of an input document to guess theInputFormat
instance to use for the conversion.This PR is intended to be merged after #557
Checklist:
Limitations:
The following points will need to be addressed in later PRs:
guess_format
function indocling/datamodel/document.py
module, once we support another XML InputFormat, sinceapplication/xml
mime type will already be ambiguous.abstract_bakend.py
that examines a partial content of a document and determines if the backend implementation supports a document type with that content. This function could then be called indocling/datamodel/document.py
module and avoid duplicated code when disambiguating mime types.text/plain
backend parser.