Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle no result from RapidOcr reader #558

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

cau-git
Copy link
Contributor

@cau-git cau-git commented Dec 10, 2024

Issue resolved by this Pull Request:
Resolves #547

Checklist:

  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

Copy link

mergify bot commented Dec 10, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@cau-git cau-git merged commit f45499c into main Dec 10, 2024
9 checks passed
@cau-git cau-git deleted the cau/fix-rapid-ocr-no-result branch December 10, 2024 15:25
cau-git added a commit that referenced this pull request Dec 17, 2024
Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Christoph Auer <[email protected]>
Copy link

@1976KALA 1976KALA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blessed

Copy link

@1976KALA 1976KALA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Comment on lines +136 to +138
)
for ix, line in enumerate(result)
]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all_ocr_cells.extend(cells)
)
for ix, line in enumerate(result)
]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
]
]

Copy link

@1976KALA 1976KALA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RapidOCR fails for NoneType
3 participants