fix: Introduce Image format options in CLI. Silence the tqdm downloading messages. #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine_options. Add RapidOcrOptions to the Union of ocr_options for PdfPipelineOptions Signed-off-by: Nikos Livathinos <[email protected]>
Signed-off-by: Nikos Livathinos <[email protected]>
nikos-livathinos
requested review from
cau-git,
PeterStaar-IBM and
dolfim-ibm
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Signed-off-by: Nikos Livathinos <[email protected]>
dolfim-ibm
reviewed
Dec 9, 2024
| # Disable tqdm prints used by HF | ||
| from tqdm import tqdm | ||
|
|
||
| tqdm.__init__ = partialmethod(tqdm.__init__, disable=True) |
There was a problem hiding this comment.
we shouldn't monkey patch, the HF library has specific options for it already
https://huggingface.co/docs/huggingface_hub/v0.26.5/en/package_reference/file_download#huggingface_hub.snapshot_download.tqdm_class
3 tasks
Signed-off-by: Nikos Livathinos <[email protected]>
cau-git
approved these changes
Dec 9, 2024
|
Maybe one more check to do is, if the input format is an image, OCR must be activated for its pipeline options (independent of the global OCR choice) |
dolfim-ibm
approved these changes
Dec 9, 2024
lucas-morin
pushed a commit
to lucas-morin/docling
that referenced
this pull request
Dec 10, 2024
…ing messages. (DS4SD#544) * fix: main: Introduce format options for Image with the same pdf pipeline_options. Add RapidOcrOptions to the Union of ocr_options for PdfPipelineOptions Signed-off-by: Nikos Livathinos <[email protected]> * fix: Silence the tqdm messages during the downloading of model files Signed-off-by: Nikos Livathinos <[email protected]> * fix: Code styling Signed-off-by: Nikos Livathinos <[email protected]> * fix: Use the HF API to disable the tqdm progress bars Signed-off-by: Nikos Livathinos <[email protected]> --------- Signed-off-by: Nikos Livathinos <[email protected]>
cau-git
pushed a commit
that referenced
this pull request
Dec 17, 2024
…ing messages. (#544) * fix: main: Introduce format options for Image with the same pdf pipeline_options. Add RapidOcrOptions to the Union of ocr_options for PdfPipelineOptions Signed-off-by: Nikos Livathinos <[email protected]> * fix: Silence the tqdm messages during the downloading of model files Signed-off-by: Nikos Livathinos <[email protected]> * fix: Code styling Signed-off-by: Nikos Livathinos <[email protected]> * fix: Use the HF API to disable the tqdm progress bars Signed-off-by: Nikos Livathinos <[email protected]> --------- Signed-off-by: Nikos Livathinos <[email protected]> Signed-off-by: Christoph Auer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to:
pipeline_optionsas for PDF. This allows the CLI parameters to be applied in case of image inputs.RapidOcrOptionsto the Union ofocr_optionsforPdfPipelineOptions.Issues resolved by this Pull Request:
Resolves #505 #208
Checklist: