Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore pydantic version pin after fixes #512

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

dolfim-ibm
Copy link
Contributor

@dolfim-ibm dolfim-ibm commented Dec 4, 2024

This PR allows the new version of pydantic 2.10.3, but limits the intermediate broken releases.

Checklist:

  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

Copy link

mergify bot commented Dec 4, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

Signed-off-by: Michele Dolfi <[email protected]>
@dolfim-ibm dolfim-ibm changed the title test: pin new docling-core changes and release pydantic pinning fix: restore pydantic version pin after fixes Dec 4, 2024
@dolfim-ibm dolfim-ibm marked this pull request as ready for review December 4, 2024 15:30
Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dolfim-ibm dolfim-ibm merged commit c830b92 into main Dec 6, 2024
9 checks passed
@dolfim-ibm dolfim-ibm deleted the test-pydantic-via-core branch December 6, 2024 08:33
lucas-morin pushed a commit to lucas-morin/docling that referenced this pull request Dec 10, 2024
* test: pin new docling-core changes and release pydantic pinning

Signed-off-by: Michele Dolfi <[email protected]>

* pin docling-core release

Signed-off-by: Michele Dolfi <[email protected]>

---------

Signed-off-by: Michele Dolfi <[email protected]>
cau-git pushed a commit that referenced this pull request Dec 17, 2024
* test: pin new docling-core changes and release pydantic pinning

Signed-off-by: Michele Dolfi <[email protected]>

* pin docling-core release

Signed-off-by: Michele Dolfi <[email protected]>

---------

Signed-off-by: Michele Dolfi <[email protected]>
Signed-off-by: Christoph Auer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants